Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Will be stuck forever if unable to download an image #3

Open
solomonhume opened this issue Jul 17, 2020 · 4 comments
Open

Will be stuck forever if unable to download an image #3

solomonhume opened this issue Jul 17, 2020 · 4 comments

Comments

@solomonhume
Copy link

This program is great. However, if I am unable to access an image, I want to skip it and move on to the next one.
This program will try endlessly if it fails to download a file.
@gurugaurav
Copy link
Owner

Can you please post your query, so that I can recreate the error.

@wcschroe
Copy link

wcschroe commented Dec 9, 2020

This made it happen for me
downloader.download("\"stock photo\" my name is troy ive got a basketball game tomorrow uh i play point guard", limit=1, adult_filter_off=False, force_replace=False, timeout=1)
excuse the weird search

@rushiai
Copy link

rushiai commented May 3, 2021

same issue!!!

[%] Indexed 0 Images on Page 1978.

===============================================

[!!]Indexing page: 1979

[%] Indexed 0 Images on Page 1979.

===============================================

[!!]Indexing page: 1980

[%] Indexed 0 Images on Page 1980.

===============================================

[!!]Indexing page: 1981

[%] Indexed 0 Images on Page 1981.

===============================================

[!!]Indexing page: 1982

[%] Indexed 0 Images on Page 1982.

===============================================

[!!]Indexing page: 1983

[%] Indexed 0 Images on Page 1983.

===============================================

[!!]Indexing page: 1984

[%] Indexed 0 Images on Page 1984.

===============================================

[!!]Indexing page: 1985

[%] Indexed 0 Images on Page 1985.

===============================================

[!!]Indexing page: 1986

[%] Indexed 0 Images on Page 1986.

===============================================

[!!]Indexing page: 1987

[%] Indexed 0 Images on Page 1987.

===============================================

[!!]Indexing page: 1988

[%] Indexed 0 Images on Page 1988.

===============================================

[!!]Indexing page: 1989

[%] Indexed 0 Images on Page 1989.

===============================================

[!!]Indexing page: 1990

[%] Indexed 0 Images on Page 1990.

===============================================

[!!]Indexing page: 1991

[%] Indexed 0 Images on Page 1991.

===============================================

[!!]Indexing page: 1992

[%] Indexed 0 Images on Page 1992.

===============================================

[!!]Indexing page: 1993

[%] Indexed 0 Images on Page 1993.

===============================================

[!!]Indexing page: 1994

[%] Indexed 0 Images on Page 1994.

===============================================

[!!]Indexing page: 1995

[%] Indexed 0 Images on Page 1995.

===============================================

[!!]Indexing page: 1996

[%] Indexed 0 Images on Page 1996.

===============================================

[!!]Indexing page: 1997

[%] Indexed 0 Images on Page 1997.

===============================================

[!!]Indexing page: 1998

[%] Indexed 0 Images on Page 1998.

===============================================

[!!]Indexing page: 1999

[%] Indexed 0 Images on Page 1999.

===============================================

[!!]Indexing page: 2000

[%] Indexed 0 Images on Page 2000.

===============================================

[!!]Indexing page: 2001

[%] Indexed 0 Images on Page 2001.

===============================================

[!!]Indexing page: 2002

[%] Indexed 0 Images on Page 2002.

===============================================

[!!]Indexing page: 2003

[%] Indexed 0 Images on Page 2003.

===============================================

[!!]Indexing page: 2004

[%] Indexed 0 Images on Page 2004.

===============================================

[!!]Indexing page: 2005

[%] Indexed 0 Images on Page 2005.

===============================================

[!!]Indexing page: 2006

[%] Indexed 0 Images on Page 2006.

===============================================

[!!]Indexing page: 2007

[%] Indexed 0 Images on Page 2007.

===============================================

[!!]Indexing page: 2008

[%] Indexed 0 Images on Page 2008.

===============================================

[!!]Indexing page: 2009

[%] Indexed 0 Images on Page 2009.

===============================================

[!!]Indexing page: 2010

[%] Indexed 0 Images on Page 2010.

===============================================

[!!]Indexing page: 2011

[%] Indexed 0 Images on Page 2011.

===============================================

[!!]Indexing page: 2012

[%] Indexed 0 Images on Page 2012.

===============================================

[!!]Indexing page: 2013

[%] Indexed 0 Images on Page 2013.

===============================================

[!!]Indexing page: 2014

[%] Indexed 0 Images on Page 2014.

===============================================

[!!]Indexing page: 2015

[%] Indexed 0 Images on Page 2015.

===============================================

[!!]Indexing page: 2016

[%] Indexed 0 Images on Page 2016.

===============================================

[!!]Indexing page: 2017

[%] Indexed 0 Images on Page 2017.

===============================================

[!!]Indexing page: 2018

[%] Indexed 0 Images on Page 2018.

===============================================

[!!]Indexing page: 2019

[%] Indexed 0 Images on Page 2019.

===============================================

[!!]Indexing page: 2020

[%] Indexed 0 Images on Page 2020.

===============================================

[!!]Indexing page: 2021

[%] Indexed 0 Images on Page 2021.

===============================================

[!!]Indexing page: 2022

[%] Indexed 0 Images on Page 2022.

===============================================

[!!]Indexing page: 2023

[%] Indexed 0 Images on Page 2023.

===============================================

[!!]Indexing page: 2024

[%] Indexed 0 Images on Page 2024.

===============================================

[!!]Indexing page: 2025

[%] Indexed 0 Images on Page 2025.

===============================================

[!!]Indexing page: 2026

[%] Indexed 0 Images on Page 2026.

===============================================

[!!]Indexing page: 2027

[%] Indexed 0 Images on Page 2027.

===============================================

[!!]Indexing page: 2028

[%] Indexed 0 Images on Page 2028.

===============================================

[!!]Indexing page: 2029

[%] Indexed 0 Images on Page 2029.

===============================================

[!!]Indexing page: 2030

[%] Indexed 0 Images on Page 2030.

===============================================

[!!]Indexing page: 2031

[%] Indexed 0 Images on Page 2031.

===============================================

[!!]Indexing page: 2032

[%] Indexed 0 Images on Page 2032.

===============================================

[!!]Indexing page: 2033

[%] Indexed 0 Images on Page 2033.

===============================================

[!!]Indexing page: 2034

[%] Indexed 0 Images on Page 2034.

===============================================

[!!]Indexing page: 2035

[%] Indexed 0 Images on Page 2035.

===============================================

[!!]Indexing page: 2036

[%] Indexed 0 Images on Page 2036.

===============================================

[!!]Indexing page: 2037

[%] Indexed 0 Images on Page 2037.

===============================================

[!!]Indexing page: 2038

[%] Indexed 0 Images on Page 2038.

===============================================

[!!]Indexing page: 2039

[%] Indexed 0 Images on Page 2039.

===============================================

[!!]Indexing page: 2040

[%] Indexed 0 Images on Page 2040.

===============================================

[!!]Indexing page: 2041

[%] Indexed 0 Images on Page 2041.

===============================================

[!!]Indexing page: 2042

[%] Indexed 0 Images on Page 2042.

===============================================

[!!]Indexing page: 2043

[%] Indexed 0 Images on Page 2043.

===============================================

[!!]Indexing page: 2044

[%] Indexed 0 Images on Page 2044.

===============================================

[!!]Indexing page: 2045

[%] Indexed 0 Images on Page 2045.

===============================================

[!!]Indexing page: 2046

[%] Indexed 0 Images on Page 2046.

===============================================

[!!]Indexing page: 2047

[%] Indexed 0 Images on Page 2047.

===============================================

[!!]Indexing page: 2048

[%] Indexed 0 Images on Page 2048.

===============================================

[!!]Indexing page: 2049

[%] Indexed 0 Images on Page 2049.

===============================================

[!!]Indexing page: 2050

[%] Indexed 0 Images on Page 2050.

===============================================

[!!]Indexing page: 2051

[%] Indexed 0 Images on Page 2051.

===============================================

[!!]Indexing page: 2052

[%] Indexed 0 Images on Page 2052.

===============================================

[!!]Indexing page: 2053

[%] Indexed 0 Images on Page 2053.

===============================================

[!!]Indexing page: 2054

[%] Indexed 0 Images on Page 2054.

===============================================

[!!]Indexing page: 2055

[%] Indexed 0 Images on Page 2055.

===============================================

[!!]Indexing page: 2056

[%] Indexed 0 Images on Page 2056.

===============================================

[!!]Indexing page: 2057

[%] Indexed 0 Images on Page 2057.

===============================================

[!!]Indexing page: 2058

[%] Indexed 0 Images on Page 2058.

===============================================

[!!]Indexing page: 2059

[%] Indexed 0 Images on Page 2059.

===============================================

[!!]Indexing page: 2060

[%] Indexed 0 Images on Page 2060.

===============================================

[!!]Indexing page: 2061

[%] Indexed 0 Images on Page 2061.

===============================================

[!!]Indexing page: 2062

[%] Indexed 0 Images on Page 2062.

===============================================

[!!]Indexing page: 2063

[%] Indexed 0 Images on Page 2063.

===============================================

[!!]Indexing page: 2064

[%] Indexed 0 Images on Page 2064.

===============================================

[!!]Indexing page: 2065

[%] Indexed 0 Images on Page 2065.

===============================================

[!!]Indexing page: 2066

[%] Indexed 0 Images on Page 2066.

===============================================

[!!]Indexing page: 2067

[%] Indexed 0 Images on Page 2067.

===============================================

[!!]Indexing page: 2068

[%] Indexed 0 Images on Page 2068.

===============================================

[!!]Indexing page: 2069

[%] Indexed 0 Images on Page 2069.

===============================================

[!!]Indexing page: 2070

[%] Indexed 0 Images on Page 2070.

===============================================

[!!]Indexing page: 2071

[%] Indexed 0 Images on Page 2071.

===============================================

[!!]Indexing page: 2072

[%] Indexed 0 Images on Page 2072.

===============================================

[!!]Indexing page: 2073

[%] Indexed 0 Images on Page 2073.

===============================================

[!!]Indexing page: 2074

[%] Indexed 0 Images on Page 2074.

===============================================

[!!]Indexing page: 2075

[%] Indexed 0 Images on Page 2075.

===============================================

[!!]Indexing page: 2076

[%] Indexed 0 Images on Page 2076.

===============================================

[!!]Indexing page: 2077

[%] Indexed 0 Images on Page 2077.

===============================================

[!!]Indexing page: 2078

[%] Indexed 0 Images on Page 2078.

===============================================

[!!]Indexing page: 2079

[%] Indexed 0 Images on Page 2079.

===============================================

[!!]Indexing page: 2080

[%] Indexed 0 Images on Page 2080.

===============================================

[!!]Indexing page: 2081

[%] Indexed 0 Images on Page 2081.

===============================================

[!!]Indexing page: 2082

[%] Indexed 0 Images on Page 2082.

===============================================

[!!]Indexing page: 2083

[%] Indexed 0 Images on Page 2083.

===============================================

[!!]Indexing page: 2084

[%] Indexed 0 Images on Page 2084.

===============================================

[!!]Indexing page: 2085

[%] Indexed 0 Images on Page 2085.

===============================================

[!!]Indexing page: 2086

[%] Indexed 0 Images on Page 2086.

===============================================

[!!]Indexing page: 2087

[%] Indexed 0 Images on Page 2087.

===============================================

[!!]Indexing page: 2088

[%] Indexed 0 Images on Page 2088.

===============================================

[!!]Indexing page: 2089

[%] Indexed 0 Images on Page 2089.

===============================================

[!!]Indexing page: 2090

[%] Indexed 0 Images on Page 2090.

===============================================

[!!]Indexing page: 2091

[%] Indexed 0 Images on Page 2091.

===============================================

[!!]Indexing page: 2092

[%] Indexed 0 Images on Page 2092.

===============================================

[!!]Indexing page: 2093

[%] Indexed 0 Images on Page 2093.

===============================================

[!!]Indexing page: 2094

[%] Indexed 0 Images on Page 2094.

===============================================

[!!]Indexing page: 2095

[%] Indexed 0 Images on Page 2095.

===============================================

[!!]Indexing page: 2096

[%] Indexed 0 Images on Page 2096.

===============================================

[!!]Indexing page: 2097

[%] Indexed 0 Images on Page 2097.

===============================================

[!!]Indexing page: 2098

[%] Indexed 0 Images on Page 2098.

===============================================

[!!]Indexing page: 2099

[%] Indexed 0 Images on Page 2099.

===============================================

[!!]Indexing page: 2100

[%] Indexed 0 Images on Page 2100.

===============================================

[!!]Indexing page: 2101

[%] Indexed 0 Images on Page 2101.

===============================================

[!!]Indexing page: 2102

[%] Indexed 0 Images on Page 2102.

===============================================

[!!]Indexing page: 2103

[%] Indexed 0 Images on Page 2103.

===============================================

[!!]Indexing page: 2104

[%] Indexed 0 Images on Page 2104.

===============================================

[!!]Indexing page: 2105

[%] Indexed 0 Images on Page 2105.

===============================================

[!!]Indexing page: 2106

[%] Indexed 0 Images on Page 2106.

===============================================

[!!]Indexing page: 2107

[%] Indexed 0 Images on Page 2107.

===============================================

[!!]Indexing page: 2108

[%] Indexed 0 Images on Page 2108.

===============================================

[!!]Indexing page: 2109

[%] Indexed 0 Images on Page 2109.

===============================================

[!!]Indexing page: 2110

[%] Indexed 0 Images on Page 2110.

===============================================

[!!]Indexing page: 2111

[%] Indexed 0 Images on Page 2111.

===============================================

[!!]Indexing page: 2112

[%] Indexed 0 Images on Page 2112.

===============================================

[!!]Indexing page: 2113

[%] Indexed 0 Images on Page 2113.

===============================================

[!!]Indexing page: 2114

[%] Indexed 0 Images on Page 2114.

===============================================

[!!]Indexing page: 2115

[%] Indexed 0 Images on Page 2115.

===============================================

[!!]Indexing page: 2116

[%] Indexed 0 Images on Page 2116.

===============================================

[!!]Indexing page: 2117

[%] Indexed 0 Images on Page 2117.

===============================================

[!!]Indexing page: 2118

[%] Indexed 0 Images on Page 2118.

===============================================

[!!]Indexing

@praveencqr
Copy link

praveencqr commented Feb 15, 2022 •
edited
Loading

I found the issue and solved it by changing the run function in the bing.py file of the package.

replace the existing run function with the below lines.

def run(self):
        total_iter = 0
        while (self.download_count < self.limit) and (total_iter < 10):
            print('\n\n[!!]Indexing page: {}\n'.format(self.page_counter + 1))
            # Parse the page source and download pics
            request_url = 'https://www.bing.com/images/async?q=' + urllib.parse.quote_plus(self.query) \
                          + '&first=' + str(self.page_counter) + '&count=' + str(self.limit) \
                          + '&adlt=' + self.adult + '&qft=' + self.filters
            request = urllib.request.Request(request_url, None, headers=self.headers)
            response = urllib.request.urlopen(request)
            html = response.read().decode('utf8')
            links = re.findall('murl&quot;:&quot;(.*?)&quot;', html)

            print("[%] Indexed {} Images on Page {}.".format(len(links), self.page_counter + 1))
            print("\n===============================================\n")

            for link in links:
                if self.download_count < self.limit:
                    self.download_image(link)
                else:
                    print("\n\n[%] Done. Downloaded {} images.".format(self.download_count))
                    print("\n===============================================\n")
                    break

            self.page_counter += 1
            total_iter += 1

        if (total_iter >= 10) and ( self.download_count == 0  ):
            raise RuntimeError

@milanvarady milanvarady mentioned this issue Jul 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@wcschroe @solomonhume @gurugaurav @praveencqr @rushiai