Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Replace option not functioning due to typo. #23

Open
seasnak opened this issue Feb 11, 2022 · 3 comments
Open

Force Replace option not functioning due to typo. #23

seasnak opened this issue Feb 11, 2022 · 3 comments

Comments

@seasnak
Copy link
Contributor

seasnak commented Feb 11, 2022

On line 24 in downloader.py there is a missing '_'.

if Path.isdir(image_dir): should be if Path.is_dir(image_dir):

@seasnak seasnak changed the title Force Replace option not function due to typo. Force Replace option not functioning due to typo. Feb 11, 2022
@ghost
Copy link

ghost commented Aug 19, 2022

Put in a pull request to fix this as I had the same issue with the typo.

@seasnak
Copy link
Contributor Author

seasnak commented Aug 22, 2022

Put in a pull request to fix this as I had the same issue with the typo.

I created a PR when I found the issue, but it hasn't been approved/merged yet.

@ghost
Copy link

ghost commented Aug 22, 2022

Put in a pull request to fix this as I had the same issue with the typo.

I created a PR when I found the issue, but it hasn't been approved/merged yet.

Yeah I realized after a little more looking that this repo is dead and I just forked it to start improving it myself for what I'm working on. First time looking at scraping images to make a classifier and I am kind of shocked how little seems to be out there for this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant