-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update message history validation to be per message #988
Conversation
punt to 060 |
@@ -380,7 +397,9 @@ def prepare_msg_history( | |||
|
|||
# validate msg_history | |||
if "msg_history" in self.validation_map: | |||
self.validate_msg_history(call_log, formatted_msg_history, attempt_number) | |||
formatted_msg_history = self.validate_msg_history( # type: ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this msg_history being mutated during validation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deep let us deep copy this
# Create a mock object for the mock_llm_api function | ||
mock_llm_api = mocker.Mock() | ||
|
||
mock_llm_api.return_value = json.dumps({"name": "Fluffy"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
rolled this into #1082 |
No description provided.