tweak hub install to always run postinstall without prompting unless … #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsimjee
reviewed
Jul 12, 2024
guardrails/cli/hub/install.py
Outdated
| install_local_models = local_models | ||
|
|
||
| try: | ||
| if module_manifest.tags and module_manifest.tags.has_guardrails_endpoint: |
There was a problem hiding this comment.
can we also add to this check that the guardrails config file does not contain use_remote_inferencing=true? If use_remote_inferencing=true, we should not show this and just assume that they want to use remote inferencing - i.e. not run post-install.
If they really wanna run post-install/use local models, they can pass a flaaaaag
|
ok what a journey. finally green and updated the behavior per comments. |
dtam
commented
Jul 12, 2024
CalebCourier
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…remote inferencing is available