fix: Status setting on guard_parse traces #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsimjee
reviewed
Jul 10, 2024
Comment on lines
+121
to
+131
| try: | ||
| if is_parent: | ||
| # Inject the current context | ||
| self.inject_current_context() | ||
| for attribute in attributes: | ||
| span.set_attribute(attribute[0], attribute[1]) | ||
|
|
||
| span.set_status(trace.Status(trace.StatusCode.OK)) | ||
| except Exception as e: | ||
| logging.error("An error occured during sopan creation: " + str(e)) | ||
| span.set_status(trace.Status(trace.StatusCode.ERROR)) |
There was a problem hiding this comment.
This is in Hub telemetry utils - the anonymized data collected by Guardrails when the enviornment is configured to send data over. Please see telemetry_utils.py for the telemetry taht's not collected by guardrails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple try clause to set the status of guard_parse calls to either "OK or ERROR" using OTEL standards as they previously where never set when creating a new span.