-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Streaming Update #798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a chunking strategy
…k in ValidationResult metadata
…vel of validator_service
…ardrails into async_streaming
Async Streaming support
Notebooks are failing for reasons unrelated to this PR, but we can't be assured of these changes until we fix them. Working on that now. |
wylansford
approved these changes
Jun 6, 2024
@@ -144,7 +144,7 @@ async def async_run( | |||
|
|||
return call_log | |||
|
|||
@async_trace(name="step") | |||
@async_trace(name="async_step") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to maybe also revert this at some point? But currently it breaks if it uses 'step' due to some async issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes:
Escape validator names in
on-fail
attributesAdd
required_model_auth
to Manifest classEnable passing serializeable metadata to api
API streaming support
Refactor guard save & enable guard.use syntax for api
Fix Notebook Runs (Fix Notebook Runs #793)
Loosen otel requirements
Use semver for package versions in checks