-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace black, isort and flake8 with ruff #725
Conversation
@CalebCourier @zsimjee I added the pre commit config yaml and installed the hook with
|
installing precommit should be included in make dev/full/all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added it to |
I pulled down the PR and tested the precommit hook, it doens't seem to work. I added a line with really long line, and it passed the hook |
but it worked on an unused variable! |
92d988a
to
9e0c326
Compare
@zsimjee Added the E501 check to test for line too long. Now tested in a fresh environment, added a new long line example in another file, the pre commit hook runs and fails - thereby stopping the commit! |
make lint
andmake autoformat
with the correct commands