-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validator imports #687
Fix validator imports #687
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
=======================================
Coverage ? 80.49%
=======================================
Files ? 123
Lines ? 7041
Branches ? 0
=======================================
Hits ? 5668
Misses ? 1373
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for this one too! SimilarToList was renamed to this one https://hub.guardrailsai.com/validator/guardrails/similar_to_previous_values |
In each notebook, it also makes sense to add a cell to the top of the notebook that installs the relevant validators ex:
This would make the notebooks self-contained and run on their own. The callout here is that this doesn't work in notebooks yet in 0.4.2, but it was fixed on main in PR https://github.com/guardrails-ai/guardrails/pull/676/files (take a look at
|
This PR fixes this issue and fixes all the notebooks so that the validators are imported from Guardrails Hub instead of the guardrails library.
Note: In the
value_within_distribution.ipynb
notebook, theSimilarToList
validator is imported but I cannot find this validator on Guardrails Hub.