Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-generation of unwanted sk-xxx file #634

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Fix auto-generation of unwanted sk-xxx file #634

merged 3 commits into from
Mar 12, 2024

Conversation

thekaranacharya
Copy link
Contributor

@thekaranacharya thekaranacharya commented Mar 12, 2024

Previously, the file was automatically generated during the execution of tests in this file using pytest. The file's contents were as follows:

# TLS secrets log file, generated by OpenSSL / Python
  • It was discovered that mocking os.environ.get was causing the file generation. Despite thorough research, no specific cause was identified.
  • After removing these mocks, the file is no longer generated, and all tests pass. It appears that the mocking was unnecessary with one exception: The mocking of os.environ is required only at one location to avoid complaints about the absence of an OpenAI API key.
  • Additionally, some other mocks have been updated.

@thekaranacharya thekaranacharya changed the title Fix auto-generation of sk-xxxxxxxxxxxxxx file Fix auto-generation of unwanted sk-xxx file Mar 12, 2024
@zsimjee zsimjee merged commit 297ca67 into main Mar 12, 2024
36 checks passed
@ShreyaR ShreyaR deleted the karan/cleanup branch March 12, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants