Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code for unsupported types #605

Merged

Conversation

aaravnavani
Copy link
Contributor

This PR fixes this issue and

  • Removes the Email, URL, PythonCode, and SQLCode classes as those are deprecated past version 0.3.0
  • Changes the warning to say version 0.4.0 instead of 0.3.0

@CalebCourier
Copy link
Collaborator

Hey @aaravnavani, thanks for starting these changes. I left a few comments for a few additional removals. Once those are done and the tests are updated we should be good to go. I noticed this was still in draft so I wanted to check if your were still planning to continue work on the PR or if you mind if we co-op it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@33bd89d). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage        ?   80.86%           
=======================================
  Files           ?      119           
  Lines           ?     6902           
  Branches        ?        0           
=======================================
  Hits            ?     5581           
  Misses          ?     1321           
  Partials        ?        0           
Flag Coverage Δ
unittests 80.86% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaravnavani aaravnavani marked this pull request as ready for review March 11, 2024 09:53
@aaravnavani
Copy link
Contributor Author

@CalebCourier Just made some additional removals and updated the tests.

@CalebCourier CalebCourier changed the base branch from main to fix_depracated_types March 11, 2024 13:03
Copy link
Collaborator

@CalebCourier CalebCourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I'm going to merge this onto a feature branch for further testing. I'll link back here so you can see it.

@CalebCourier CalebCourier merged commit 845e992 into guardrails-ai:fix_depracated_types Mar 11, 2024
36 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants