-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code for unsupported types #605
Remove deprecated code for unsupported types #605
Conversation
Hey @aaravnavani, thanks for starting these changes. I left a few comments for a few additional removals. Once those are done and the tests are updated we should be good to go. I noticed this was still in draft so I wanted to check if your were still planning to continue work on the PR or if you mind if we co-op it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
=======================================
Coverage ? 80.86%
=======================================
Files ? 119
Lines ? 6902
Branches ? 0
=======================================
Hits ? 5581
Misses ? 1321
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@CalebCourier Just made some additional removals and updated the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I'm going to merge this onto a feature branch for further testing. I'll link back here so you can see it.
845e992
into
guardrails-ai:fix_depracated_types
This PR fixes this issue and