Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Raw LLM response: null -> True #604

Merged
merged 12 commits into from
Feb 28, 2024
Merged

Conversation

thekaranacharya
Copy link
Contributor

@thekaranacharya thekaranacharya commented Feb 27, 2024

Add fix for #479

  • Remove super().verify() method, clean up the code and convert to a normal method which will be used by all the inherited classes
  • New method: is_optional_and_null() now returns True if field is optional and null, else False
  • Gets called in all child classes' verify() method -> if True, will return None rather than simply returning the boolean itself.

Other updates to code:

  • Add bug-fixes in OpenAI v1 implementation
    • Correctly parse OpenAI output - either using content or function_call arguments
  • Other minor bug-fixes

@thekaranacharya thekaranacharya marked this pull request as ready for review February 28, 2024 00:55
@thekaranacharya thekaranacharya changed the title Bugfix Bugfix: Raw LLM response: null -> True Feb 28, 2024
@thekaranacharya thekaranacharya merged commit 1a86ad0 into main Feb 28, 2024
60 checks passed
@ShreyaR ShreyaR deleted the karan/bugfix-479 branch March 29, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants