Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty check on setup key #531

Merged
merged 4 commits into from
Jan 10, 2024
Merged

fix empty check on setup key #531

merged 4 commits into from
Jan 10, 2024

Conversation

CalebCourier
Copy link
Collaborator

This PR fixes creating the property path during validation for the ValidatorLogs. Previously it wouldn't append the array index for the first element in a list because python considers 0 falsey.

@CalebCourier CalebCourier requested review from zsimjee and a team January 9, 2024 19:47
@zsimjee zsimjee merged commit 8833c05 into main Jan 10, 2024
60 checks passed
@zsimjee zsimjee deleted the property-path-fix branch January 10, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants