Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add async_validate() calls to all validators #831

Open
wylansford opened this issue Jun 14, 2024 · 2 comments
Open

[feat] Add async_validate() calls to all validators #831

wylansford opened this issue Jun 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@wylansford
Copy link
Contributor

Description
Even if we use async mode, async ends up calling synchronous validate() calls. We can add an async call to all validators

Why is this needed
Real Async support

Implementation details
Add async_validate() as a function to implement in base_validator, implement this function in all validators

End result

@wylansford wylansford added the enhancement New feature or request label Jun 14, 2024
Copy link

github-actions bot commented Aug 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Copy link

github-actions bot commented Sep 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants