Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports activeTab access for plugin settings #297

Merged
merged 3 commits into from
Jun 2, 2024
Merged

Conversation

dkastl
Copy link
Member

@dkastl dkastl commented May 31, 2024

Fixes #296

Changes proposed in this pull request:

  • Adds some Javascript to support "active tab" selection for plugin settings.

Fixes #296

Signed-off-by: Daniel Kastl <daniel@georepublic.de>
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl dkastl requested review from smellman and sanak May 31, 2024 10:45
@dkastl dkastl changed the base branch from main to next May 31, 2024 10:50
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl dkastl added this to the v5.1.0 milestone May 31, 2024
Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this.
Thanks a lot!

@dkastl dkastl merged commit 9fc8707 into next Jun 2, 2024
10 checks passed
@dkastl dkastl deleted the dkastl/issue296 branch June 2, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct link to GTT settings tab not working
2 participants