Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenLayers 9.0 and Google support #273

Merged
merged 10 commits into from
Feb 26, 2024
Merged

OpenLayers 9.0 and Google support #273

merged 10 commits into from
Feb 26, 2024

Conversation

dkastl
Copy link
Member

@dkastl dkastl commented Feb 26, 2024

Changes proposed in this pull request:

  • Updates to OpenLayers 9.0
  • Supports Google source (with example)

Unresolved issues:

  • Google source seems to have issues with the layer mask.

@gtt-project/maintainer

@dkastl
Upgrades to OpenLayers 9
bdd465d 
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl
Adds Google Maps config and example
2ae6722 
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl
Improves example
8aa9625 
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl
Do not apply filter for Google source
43f9403 
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl
Updates Node version
6d5b08f 
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl
Copy link
Member Author

dkastl commented Feb 26, 2024

@sanak , it seems the CI fails because redmine:master now uses a different Ruby version, but I don't remember what changes are necessary to fix this.

@dkastl
Excludes in build matrix
7767690 
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl dkastl changed the base branch from main to next February 26, 2024 05:21
@dkastl
Uses Node 20
179348d 
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl
Exclude fix redmine_version
fc20e1d 
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl
Updates excludes
6f74e8f 
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
sanak
sanak approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkastl LGTM!

@dkastl
Removes console log
c52b98f 
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
smellman
smellman approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@smellman smellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkastl dkastl merged commit 7ade89b into next Feb 26, 2024
10 checks passed
@dkastl dkastl deleted the ftr/ol9 branch February 26, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smellman smellman smellman approved these changes

@sanak sanak sanak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkastl @smellman @sanak