-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes /issues/new
map_rotation issue
#269
Fixes /issues/new
map_rotation issue
#269
Conversation
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
95e4a0a
to
b5f0c7e
Compare
/issues/new
map_rotation issue
&& !target.hasChildNodes() | ||
) { | ||
window.createGttClient(target); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smellman (CC: @dkastl)
Related with #257 and PR:#258, I don't know why these changes solve the following error in #268 description.
With this change the map will not initialize correctly when the project change triggers a dynamic loading of content.
So, reviewing these changes is really helpful. 🙇
Adding contentObserver()
line caused to generate 2 duplicated maps when clicking on the map, so I don't include the line.
…-not-handle-the-plugin-correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #268 .
Changes proposed in this pull request:
@project
@dkastl @smellman
I added the followings:
/issues/new
does not handle the plugin correctly. #268 description.