Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 864 doc updates #1

Merged

Conversation

mkavulich
Copy link

Hi Gillian, since you're working on major updates I thought it was best to make my changes for PR 864 on top of your branch. I hope this isn't too disruptive; let me know if you have any questions or if I can help out with anything!

Updates for ufs-community#864:

  • Remove mentions of turning off task_get_obs_* tasks
  • Re-work the section with the table describing the verification tasks; this includes some clarifications and corrections around which tasks are activated when
  • Documents new behavior for *_OBS_DIR variables and task_get_obs_* tasks
  • Remove mention of non-existent "OBS_DIR" variable

RTD for my branch can be found here: https://ufs-srweather-app-mkavulich.readthedocs.io/en/latest/index.html

Copy link
Owner

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkavulich Looks good to me! Do you have any additional changes you'd like to make, or can I merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants