Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript issue with a missing generic on "Message" #779

Closed
lostpebble opened this issue Mar 14, 2019 · 2 comments
Closed

Typescript issue with a missing generic on "Message" #779

lostpebble opened this issue Mar 14, 2019 · 2 comments

Comments

@lostpebble
Copy link

lostpebble commented Mar 14, 2019

Environment

  • OS name, version and architecture: Windows 10
  • Node installation method : nvm
  • Package name and version grpc@1.19.0 and grpc@1.18.0
../../node_modules/grpc/index.d.ts:69:50 - error TS2314: Generic type 'Message<T>' requires 1 type argument(s).

69     [name: string]: GrpcObject | typeof Client | Message;
                                                    ~~~~~~~

I've been running into all kinds of type errors with grpc and google-gax since trying to update my @google-cloud dependencies. This is one of them - these kinds of errors should definitely be caught by the Typescript build process before releasing the library, so I'm kind of surprised that it made it through.

I use esModuleInterop: true and "allowSyntheticDefaultImports": true, which was causing issues in google-gax for some reason - but I've turned them off to test and this grpc error remains the same, so its not related to those.

@murgatroid99
Copy link
Member

See #176, #393, #422, and #425, and this should have been fixed by protobufjs/protobuf.js#1086. Do you have a separate (possibly transitive) dependency on Protobuf.js that is pinned to an earlier version?

@lostpebble
Copy link
Author

Ah that could be it.. I'm using a few libraries across @google-cloud. Trying to get them to all play nice is always a bit of a pain. I've rolled back for now because of some other TypeScript issues in google-gax, but will try again when they have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants