Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kotlinx coroutines versions are out of date (in bazel) #280

Open
jeffzoch opened this issue Aug 12, 2021 · 3 comments
Open

kotlinx coroutines versions are out of date (in bazel) #280

jeffzoch opened this issue Aug 12, 2021 · 3 comments

Comments

@jeffzoch
Copy link

IO_GRPC_GRPC_KOTLIN_ARTIFACTS = [
    "com.google.guava:guava:29.0-jre",
    "com.squareup:kotlinpoet:1.5.0",
    "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.5",
    "org.jetbrains.kotlinx:kotlinx-coroutines-debug:1.3.5",
]

has a few pretty old versions with breaking changes occurring in channel apis. I get errors when trying to use 1.4.3 (which itself is out of date with newer versions). org.jetbrains.kotlinx:kotlinx-coroutines-core can probably just be org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm too.

The rules in WORKSPACE are also old but those are easier to opt out of it seems since they are only loaded if they dont exist already

@jeffzoch jeffzoch changed the title Bazel versions are out of date kotlinx coroutines versions are out of date (in bazel) Aug 12, 2021
@Kernald
Copy link
Contributor

Kernald commented Sep 6, 2021

Compiling gRPC-Kotlin with 1.4.3 was fine for me, as far as I can tell. Migrating to 1.5 will require a tiny bit of work at least:

stub/src/main/java/io/grpc/kotlin/ServerCalls.kt:269:34: warning: 'offer(E): Boolean' is deprecated. Deprecated in the favour of 'trySend' method                               
            if (!requestsChannel.offer(message)) {                                                                                                                                                                   
                                 ^                 

Switching to trySend is quite straightforward (but didn't exist before 1.5.0, so would be a breaking change).

@jamesward
Copy link
Collaborator

cc @aragos

@jesseschalken
Copy link
Contributor

jesseschalken commented Sep 5, 2022

I think this was fixed in #327 and #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants