xdsrouting: remove env variable for routing #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
force-pushed
the
xds_routing_remove_env_v
branch
from
31688ca
to
965e5c6
Compare
easwars
approved these changes
Jul 24, 2020
| @@ -317,19 +317,26 @@ func TestXDSResolverGoodServiceUpdate(t *testing.T) { | |||
|
|
|||
| waitForWatchService(t, xdsC, targetStr) | |||
|
|
|||
| // // Replace random number function to only generate 0. This is necessary so | |||
menghanl
force-pushed
the
xds_routing_remove_env_v
branch
from
d38b7ea
to
ea82fed
Compare
menghanl
added a commit
that referenced
this pull request
Jul 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So routing is enabled by default.