Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extra space around sql #471

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Conversation

fearless0307
Copy link
Contributor

No description provided.

@marksweb
Copy link
Collaborator

What's the actual fix here @fearless0307?

It looks like the markup is the same, just with added line breaks 😂

@fearless0307
Copy link
Contributor Author

fearless0307 commented Feb 12, 2022

@marksweb
if we use <p> tag, it ignore surrounded space, but if we use <pre> tag, it also consider the surrounded space.
Same issue was here, <textarea> tag was taking surrounded space as value in codemirror editor.

@marksweb
Copy link
Collaborator

@fearless0307 ah yes I thought that might be why the formatting alone fixed it 👍

Great work. As always I assumed it more complicated & thought it was a problem in the JS!

@marksweb marksweb merged commit 670a2b2 into explorerhq:master Feb 12, 2022
@marksweb
Copy link
Collaborator

Released in 2.4.1

https://pypi.org/project/django-sql-explorer/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants