-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing localization for all UI messages and russian localization #450
Conversation
belonesox
commented
Jul 17, 2021
- Preparing localization for all UI messages («trans», «blocktrans»)
- Add russian localization for all these messages
Impressive @belonesox! Thank you for the contribution, will check this out properly soon. |
@belonesox Could you delete the They're generated files & typically a generated file isn't committed to git. |
OK, done, but there are different rules for these, and I follow that |
@belonesox in my experience, packages don't need to ship with mo files because the Django project using the app will define its supported languages and the person deploying the app runs compile messages which then creates the mo files. One of the main packages I use in this circumstance being Django allauth. I can certainly build the command into the release pipeline. That way they'd go into the pip package. |
Theoretically, it possible to not store it (I cannot remember a project with such paradigm, just checked almost all my django deps wheels — and cannot find such project), but then
|
@belonesox Ah ok, if django stores it's Thanks for providing that extra info! |
OK, return "mo" back. |
Is something else need to merge this? |
@belonesox I added some comments about the way you've added the translation tags. Feel free to share any thoughts or I could merge & then make changes myself. |
Sorry, I dont see them. There I should read these comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@belonesox Hopefully you can see comments here.
@belonesox I've released this is 2.3 |
* First translation of all message already prepared for localication * add trans/blocktrans tags for all UI literals in templates * add trans/blocktrans tags for all UI literals in templates. Add russian translation for all this staff * Sorry fix a typo * generated localization files excluded from git * generated localization files excluded from git * force store compiled russian messages * Enable mo files back * add load i18n to some templates, now tests OK * fix explorerhq/sql-explorer#450 (comment) * fix explorerhq/sql-explorer#450 (comment)
* First translation of all message already prepared for localication * add trans/blocktrans tags for all UI literals in templates * add trans/blocktrans tags for all UI literals in templates. Add russian translation for all this staff * Sorry fix a typo * generated localization files excluded from git * generated localization files excluded from git * force store compiled russian messages * Enable mo files back * add load i18n to some templates, now tests OK * fix explorerhq/sql-explorer#450 (comment) * fix explorerhq/sql-explorer#450 (comment)