Fix #430 - CSV exports to include a BOM #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Exports need to include a BOM #430 - CSV exports to include a BOM
BOM_UTF8 added via the
CSVExporterclass.A few existing tests rely on this class and break when adding a BOM. This PR makes them independent of whether a BOM is there or not, and adds a dedicated test for the BOM. Hope that approach is ok.
Test suite passes and using the
/test_projectthe Japanese character ガ displays properly when opening the csv in excel.Fix paths of requirement files in
/test_project/start.sh