Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django update #386

Merged
merged 2 commits into from
May 5, 2020
Merged

Django update #386

merged 2 commits into from
May 5, 2020

Conversation

Anton-Shutik
Copy link
Contributor

@Anton-Shutik Anton-Shutik commented Apr 24, 2020 •
edited
Loading

Updated to min supported django version.

@Anton-Shutik
Copy link
Contributor Author

@sramirezgroveco Could you pls take a look ?

sramirezgroveco
sramirezgroveco approved these changes May 5, 2020
View reviewed changes
Copy link

@sramirezgroveco sramirezgroveco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this goes out, let's make sure we have a monitor plan in the PR or somewhere to validate the health of the release.

@Anton-Shutik
Copy link
Contributor Author

@sramirezgroveco It won't affect our site, since we have the requirements pinned to specific version. And it will not affect us since we're already on django 2.2

@Anton-Shutik Anton-Shutik merged commit c23b8d4 into master May 5, 2020
@Anton-Shutik Anton-Shutik deleted the upgrade-django branch May 5, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sramirezgroveco sramirezgroveco sramirezgroveco approved these changes

@chrisclark chrisclark Awaiting requested review from chrisclark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anton-Shutik @sramirezgroveco