Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Django's cookie name setting instead of hardcoded name #370

Merged
merged 3 commits into from
Dec 8, 2020

Conversation

mounirmesselmeni
Copy link
Contributor

@mounirmesselmeni mounirmesselmeni commented Aug 21, 2019

When some one uses custom csrf cookie name in Django, it needs to override the explorer base.html and js files to make it work.
Default Django CSRF cookie name is csrftoken, it can be changed via settings and if so third party apps should support it out of the box.

@Anton-Shutik
Copy link
Contributor

@mounirmesselmeni What's up ? Any description on the PR ?

@mounirmesselmeni
Copy link
Contributor Author

mounirmesselmeni commented Feb 17, 2020

@Anton-Shutik When some one uses custom csrf cookie name in Django, it needs to override the explorer base.html and js files to make it work.
Default Django CSRF cookie name is csrftoken, it can be changed via settings and if so third party apps should support it out of the box. That's basically what this PR is about

@Anton-Shutik
Copy link
Contributor

@mounirmesselmeni Cool, can we add setting description here so people know about that ?

I'd also love to see some tests on that

Thanks for contributing!

@marksweb
Copy link
Collaborator

marksweb commented Dec 7, 2020

@mounirmesselmeni Looking at this, it'd be good to get it merged 👍

@chrisclark
Copy link
Collaborator

Looks good to me. @marksweb feel free to resolve conflicts and merge! Thanks!

@mounirmesselmeni
Copy link
Contributor Author

@marksweb I updated the PR and added tests. For adding doc about the setting I don't think it's necessary as we will just use the default Django settings for that. Nothing specific for explorer app.

@marksweb
Copy link
Collaborator

marksweb commented Dec 8, 2020

@mounirmesselmeni Excellent work, we do love extra tests!

@marksweb marksweb merged commit c646a5b into explorerhq:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants