Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EXPLORER_SCHEMA_EXCLUDE_TABLE_PREFIXES #368

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

ramonsaraiva
Copy link
Contributor

@ramonsaraiva ramonsaraiva commented Aug 10, 2019

@ramonsaraiva
Copy link
Contributor Author

I thought about excluding explorer_ from the defaults as well, but some unit tests broke and seems like they're expecting explorer_ to be in.. I don't think users would be interested on seeing explorer_ tables in the schema viewer when writing queries. Maybe in a future PR.

@ramonsaraiva
Copy link
Contributor Author

@chrisclark hey :-)

@meIias
Copy link
Contributor

meIias commented Sep 23, 2019

looks reasonable to me. Merging, thanks for the PR @ramonsaraiva!

@meIias meIias merged commit 864a18a into explorerhq:master Sep 23, 2019
@meIias
Copy link
Contributor

meIias commented Sep 23, 2019

Looks like this should be reverted as it now fails RST file validation:

  `long_description` has syntax errors in markup and would not be rendered on PyPI.
    line 368: Error: Unknown target name: "auth".

@ramonsaraiva
Copy link
Contributor Author

ramonsaraiva commented Sep 23, 2019

I don't quite understand that error..

@meIias
Copy link
Contributor

meIias commented Sep 24, 2019

Part of the pypi upload process involved validation against the README.rst file, that validation failed when the prefixes were not fully defined like django.contrib.auth. I suppose that's why @chrisclark set it the way he did

@ramonsaraiva
Copy link
Contributor Author

django.contrib.auth is not a prefix of a table... the documentation is wrong cause it is not excluding those tables from the schemas disaplayed in Explorer.

The table prefixes are in fact auth_, etc...

Not sure what process is validating the README file but I don't understand why having auth_ as a prefix is incorrect.

@meIias
Copy link
Contributor

meIias commented Sep 24, 2019

I would try running the README.rst with your changes in it against an RST validator (like this one https://pypi.org/project/rstvalidator/). it throws the same "unknown target name" error.

After a bit of investigation it seems to me like it's just being referenced incorrectly. rather than auth_ i believe you can do :ref:auth and it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants