Add i18n and Chinese translation. #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yihuang I'm just going over old PRs and this is quite old now - could you resolve the conflicts on this please & I'll merge it? |
thanks, rebased now. |
Closed
Closed
marksweb
pushed a commit
that referenced
this pull request
Jul 14, 2021
* Translates expression for duration Fixes incorrect translation of expression with blocktrans introduced in PR #345. Django docs show that expressions must be bound to a variable before being used inside a blocktrans (now blocktranslate since 3.1) https://docs.djangoproject.com/en/2.2/topics/i18n/translation/#blocktrans-template-tag * Uses newer format for expression binding This newer format is easier to read, and available since at least django 1.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% complete though.