Fix Oracle Query Failure caused by TextField on Group By Clause #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetkucuk
changed the title
ahmetkucuk
changed the title
|
@ahmetkucuk I'm just going over old PRs and this is quite old now - is this still relevant? |
|
I think it is relevant because I still use the library from my own fork because of this issue. |
|
@ahmetkucuk thanks. I don't have any access to oracle so will merge this on the basis that you're running it successfully. However, could you please merge master back to your fork to update this PR, because there's a 0008 migration in master which looks like it'll conflict with these changes. |
syntax fix
Make text fields nullable Make non-nullable
|
I updated the migrations. I didn't check if there are any new Oracle issues but I will open another PR if there is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotation in
Queryputssqlanddescriptioninto Group By clause which fails in Oracle. In Oracle, NCLOB cannot be used in group by clause. See similar issue report:https://code.djangoproject.com/ticket/24096
Seems like there are two solution, either
.defer('sql', 'description')or using prefetch and count. Former will create several extra queries when we try to reach those attributes. Implemented approach will create 1 extra query to fetchquerylog_set.TextField cannot be nullable in Oracle.