Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a better blacklist check #412

Closed
marksweb opened this issue Oct 15, 2020 · 0 comments
Closed

Build a better blacklist check #412

marksweb opened this issue Oct 15, 2020 · 0 comments
Assignees
Milestone

Comments

@marksweb
Copy link
Collaborator

The blacklist checking is fairly basic and can be problematic because it doesn't differentiate between "drop" and "raindrop" for example.

e.g. "DROP" is a blacklisted term. However it's fine as part of another word, e.g. "DROPKICK" or "RAINDROP"...the SQL compiler isn't going to tokenize these things to produce "DROP".

Amend the blacklist checking to only raise an issue if the blacklisted term is surrounded by non-alphanumeric characters or start/end, so it'll flag "DROP", "DROP something", "(DROP something)"...but not "DROPKICK something"

@marksweb marksweb self-assigned this Oct 15, 2020
marksweb added a commit that referenced this issue Oct 15, 2020
@marksweb marksweb added this to the 2.1 milestone Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant