No longer working on Python 3 #288
Comments
|
Yikes. I will fix now. I will change to Sorry. Any idea why tests didn't catch it? Travis tests against py3. |
|
Good question; either you're adding the explorer module in the pythonpath (which you shouldn't do), or you're not reaching the schema file from travis. Thanks for fixing! |
|
In pip repository still old version 1.1 |
Closed
nuclearace
added a commit
to nuclearace/django-sql-explorer
that referenced
this issue
May 14, 2017
* 'master' of https://github.com/groveco/django-sql-explorer: 1.1.1 - fixes explorerhq#288 Release 1.1.0 rewinding file handler before uploading readme requirements updates removing tinys3 in favor of boto Escape strings from the database when rendering Fix duplicate test names Remove unused lambda expressions assigned to "_" Fix code formatting issue Add on_delete argument to foreign key fields Conditionally import reverse and reverse_lazy depending on django version update factory-boy dependency version to fix tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/groveco/django-sql-explorer/blob/8168d66050e5bf3fe8f6fcbeb1a9bcb8318eb1a9/explorer/schema.py#L3
This line is breaking everything. It should be
from explorer.app_settings import ....Better yet, all imports should move to relative imports with
from .app_settings import ....I can PR either fixes.
The text was updated successfully, but these errors were encountered: