Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more consistent sizes for object icons #272

Merged
merged 26 commits into from
Aug 30, 2018
Merged

Conversation

shanberg
Copy link
Contributor

Updated icons attached

Icons Update.zip

@shanberg shanberg changed the title 267 update object icons WIP more consistent sizes for object icons Aug 28, 2018
@kaitmore kaitmore changed the title WIP more consistent sizes for object icons fix: more consistent sizes for object icons Aug 30, 2018
kaitmore
kaitmore previously approved these changes Aug 30, 2018
Copy link
Contributor

@kaitmore kaitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import React from "react";
import Icon from "../Icon";

export default function ObjectDownload(props) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 78 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Aug 30, 2018

Code Climate has analyzed commit 3fe1a34 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.2% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@kaitmore kaitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanberg shanberg merged commit ac44cba into master Aug 30, 2018
@shanberg shanberg deleted the 267-update-object-icons branch August 30, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants