Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ForeignObject support for react native #430

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

jalooc
Copy link
Contributor

@jalooc jalooc commented Apr 13, 2020

SVGR currently drops <foreignObject> tags, even though they're supported by react-native-svg.

Summary

This PR adds foreignObject to the map of recognised tags (elementToComponent).

@vercel
Copy link

vercel bot commented Apr 13, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/gregberge/svgr/1f95cx0s2
✅ Preview: https://svgr-git-fork-jalooc-foreign-object-rn-support.gregberge.now.sh

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #430 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   86.53%   86.53%           
=======================================
  Files          31       31           
  Lines         557      557           
  Branches      153      153           
=======================================
  Hits          482      482           
  Misses         60       60           
  Partials       15       15           
Impacted Files Coverage Δ
...bel-plugin-transform-react-native-svg/src/index.js 97.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30bb85...c42d2e9. Read the comment docs.

@gregberge
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants