-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planet 5484 create zip on tag #1182
Conversation
3cea92a
to
d7cb601
Compare
39347ec
to
85496fd
Compare
00587d1
to
0c2c2da
Compare
* Same changes as were applied for master theme here greenpeace/planet4-master-theme#1182
* Same changes as were applied for master theme here greenpeace/planet4-master-theme#1182
114b078
to
5af0cb2
Compare
Looks like updating the lock file was breaking our php tests. This seems to be the lock file of an older install. Shouldn't be an issue as the lock file is only used in our CI for this repo. |
- run: npm run build | ||
- run: | ||
name: "Remove files we don't want in the zip file." | ||
command: rm -rf .circleci .git .githooks assets/src bin tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included the ones of which I was sure they wouldn't be needed in the zip. Maybe there's some others which would make sense to exclude here? The total zip size is currently about 1.8MB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
* Same changes as were applied for master theme here greenpeace/planet4-master-theme#1182
43c26a8
to
ba92fc4
Compare
* Same changes as were applied for master theme here greenpeace/planet4-master-theme#1182
PLANET-5484 Get corresponding upload url for tag PLANET-5484 Exclude node_modules instead of remove (faster) PLANET-5484 Get upload url in same step * Right, CircleCI environment is local to a step, so the previous attempt of assigning in different steps couldn't work. Instead get the value in the same step, and use literal file name. PLANET-5484 Cat upload_url to tmp file instead PLANET-5484 Use dedicated token * The existing token didn't work to upload packages. PLANET-5484 jq format curl resopnse PLANET-5484 Try if slim image with fetch is faster PLANET-5484 Req composer installer dep PLANET-5484 add missing file extension PLANET-5484 Try skip puppeteer and chromium env vars PLANET-5484 Use fork from our org instead PLANET-5484 Also add python * `npm ci` gives some errors for python not being present, even though it continues to complete successfully. Still it causes the command to take a bit longer while it's looking for python. PLANET-5484 Also add make PLANET-5484 Add openssh and g++ too PLANET-5484 Run apk add before checkout step PLANET-5484 Add openssh-client PLANET-5484 make curl fail job, name commands PLANET-5484 Add step descriptions PLANET-5484 Sanity check on zip file size
ba92fc4
to
053f272
Compare
Ref: https://jira.greenpeace.org/browse/PLANET-5484