Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes all suspended tabs on uninstalling #418

Closed
brajmohans opened this issue Jul 19, 2016 · 3 comments
Closed

Closes all suspended tabs on uninstalling #418

brajmohans opened this issue Jul 19, 2016 · 3 comments

Comments

@brajmohans
Copy link

I just uninstalled this plugin but to my surprise it dragged away all suspended tabs with it.
I couldn't see any valid reason for this behaviour. Its just inconvenient

@ronin13
Copy link
Contributor

ronin13 commented Sep 4, 2016

This is because the extension is not using event pages.

Hence,

    //wishful thinking here that a synchronus iteration through tab views will enable them
    //to unsuspend before the application closes
    chrome.runtime.onSuspend.addListener(function () {
        chrome.extension.getViews({type: 'tab'}).forEach(function (view) {
            view.location.reload();
        });
    });

in background.js never gets triggered.

It needs the background pages to be converted into event pages as described here: https://developer.chrome.com/extensions/event_pages

@dandv
Copy link

dandv commented Oct 18, 2016

This is a super critical bug :-/

I'm going to uninstall right now, before it suspends anything.

@deanoemcke
Copy link
Collaborator

Please refer to this guide on why this happens and how to recover lost tabs: #526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants