Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estop support #40

Open
yoft opened this issue Aug 24, 2023 · 10 comments
Open

Estop support #40

yoft opened this issue Aug 24, 2023 · 10 comments

Comments

@yoft
Copy link

yoft commented Aug 24, 2023

Hi,
Is it difficult to add estop support to this driver? And what features does this add?

Thanks!

@terjeio
Copy link
Contributor

terjeio commented Aug 24, 2023

Is it difficult to add estop support to this driver?

No, I'll add it in the next commit.

And what features does this add?

It is a little less harsh than a soft reset, it will not immediately reinitialize the controller. Unlike a soft reset via the reset pin the e-stop state cannot be cleared before the input signal is deasserted (e-stop switch unlocked) so a tad safer and this is perhaps the major difference.
Note that for safety reasons one should never rely on the controller to shut down motors on a critical event, relays should be added, wired to the e-stop/reset switch, to cut power to them. See links from this search for more.

@yoft
Copy link
Author

yoft commented Aug 25, 2023

Hi @terjeio,
You're a legend!

I'll wire the signal from the emergency contactor auxiliary contact.

Is it possible to also add support for HC-05 bluetooth?

Thanks again!

@yoft yoft closed this as completed Aug 25, 2023
@yoft
Copy link
Author

yoft commented Aug 25, 2023

Sorry, didn't mean to close, new to github issues.

@terjeio
Copy link
Contributor

terjeio commented Aug 25, 2023

Is it possible to also add support for HC-05 bluetooth?

Which board? An interrupt capable aux input is required.

@yoft
Copy link
Author

yoft commented Aug 25, 2023

Which board? An interrupt capable aux input is required.

BTT SKR 1.3, I haven't checked which pins are interrupt capable, is it easy to find?

@yoft yoft reopened this Aug 25, 2023
@terjeio
Copy link
Contributor

terjeio commented Aug 25, 2023

I have mapped P0.2 in the Servo header and added the Bluetooth plugin in the latest commit. Note that USB comms has to be enabled as default since the driver only supports one serial port. I have only tested with a Re-ARM board, I leave it to you to verify with the SKR board as I do not have one.

@yoft
Copy link
Author

yoft commented Sep 1, 2023

Just an update, I've been unsuccessful in setting up the bluetooth as my usb port is faulty, leaving only the single serial port.

I'm yet to verify the estop, that'll probably be tomorrow.

I've decided to replace the board with BTT Octopus Pro STMF446, so I'll see you in that repo soon.

Thanks,

@GundamModeler
Copy link

Which pin do I wire my E-Stop to? The pin labeled 2.0 and GND in servo header?
SKRpinoutpic

@yoft
Copy link
Author

yoft commented Oct 17, 2023

Which pin do I wire my E-Stop to? The pin labeled 2.0 and GND in servo header?
SKRpinoutpic

Hi,
I never got a chance to verify functionality, but I believe the estop replaces the reset pin, P0.18 in the board map. You will have to compile with estop enabled on this line if compiling manually.

Please let us know the outcomes!

@GundamModeler
Copy link

ahh thx for the fast reply, I will test in the morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants