Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minimum landuse zoom levels more consistent #809

Merged

Conversation

matthijsmelissen
Copy link
Collaborator

The minimum zoom levels are currently rather inconsistent. For example meadow
and farmland have a different minimum zoom level. This PR aims to improve this.

This PR lets all major landuse start at z10 (like most do already), except for
wood / forest. Smaller objects will start at z13.

Concrete changes in minimum zoom levels:

  • tourism=camp_site, tourism=caravan_site, tourism_picnic_site from z13 to z10
  • landuse=quarry from z11 to z10
  • landuse=garages from z12 to z13
  • landuse=farmyard, landuse=farm, landuse=farmland from z9 to 10
  • landuse=village_green from z11 to z10
  • natural=desert from z8 to z10 (solves partially Change rendering natural=desert #773)
  • aeroway=apron, aeroway=aerodrome from z12 to z10
  • highway=services, highway=rest_area from z14 to z10

@pnorman
Copy link
Collaborator

pnorman commented Aug 1, 2014

Wow - it was a mishmash of zooms.

Because there were already features from this layer being rendered, it shouldn't significantly negatively impact performance even though we may end up rendering more.

@Klumbumbus
Copy link

It's good to rework the zoom levels, but I think some changes are made in the wrong direction, e.g. farmland to z10? The map at z1-z7 currently looks (sorry for that) pretty ugly. So with this change also z8 and z9? Why can't the landuses which cover the most like farmland, meadow, forrest, dessert,... start at z7 or even earlier?

@Klumbumbus
Copy link

@dieterdreist
Copy link

Il giorno 02/ago/2014, alle ore 12:42, Klumbumbus notifications@github.com ha scritto:

Why can't the landuses which cover the most like farmland, meadow, forrest, dessert,... start at z7 or even earlier?

I agree with this. It would be a bit out of scale (usually one should generalize in these scales), but I believe it would be an overall improvement, because it would give a much better impression of coverage and topography

@matthijsmelissen
Copy link
Collaborator Author

I agree that the low zoomlevels look ugly. However, the roads are already quite hard to see on the low zoomlevels, so I think we would first need to do more tweaking with the landuse and road colors before we can render all landuse on for example z9.

I would prefer to leave that out of the scope of this PR, and look at the low zoom levels at a later point.

In any case it doesn't make sense to render landuse=farmland, but to hide landuse=residential, on z9.

@imagico
Copy link
Collaborator

imagico commented Aug 2, 2014

In any case it doesn't make sense to render landuse=farmland, but to hide landuse=residential, on z9.

Urban landuse is not rendered at z=8/9 because external vmap0 data is used instead.

The minimum zoom levels are currently rather inconsistent. For example meadow
and farmland have a different minimum zoom level. This PR aims to improve this.

This PR lets all major landuse start at z10 (like most do already), except for
wood / forest. Smaller objects will start at z13.

Concrete changes in minimum zoom levels:

* tourism=camp_site, tourism=caravan_site, tourism_picnic_site from z13 to z10
* landuse=quarry from z11 to z10
* landuse=garages from z12 to z13
* landuse=farmyard, landuse=farm, landuse=farmland from z9 to 10
* landuse=village_green from z11 to z10
* natural=desert from z8 to z10 (solves partially gravitystorm#773)
* aeroway=apron, aeroway=aerodrome from z12 to z10
* highway=services, highway=rest_area from z14 to z10
@matthijsmelissen
Copy link
Collaborator Author

Rebased.

@Klumbumbus Klumbumbus mentioned this pull request Aug 26, 2014
gravitystorm added a commit that referenced this pull request Aug 28, 2014
Make minimum landuse zoom levels more consistent
@gravitystorm gravitystorm merged commit 4d02591 into gravitystorm:master Aug 28, 2014
@matthijsmelissen matthijsmelissen deleted the landcover-minzoom branch September 25, 2014 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants