Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rendering of residential, unclassified, cycleway, path, track highway areas #4096

Merged
merged 5 commits into from
Apr 15, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions project.mml
Original file line number Diff line number Diff line change
Expand Up @@ -642,15 +642,15 @@ Layer:
(SELECT
way,
COALESCE((
'highway_' || (CASE WHEN highway IN ('residential', 'unclassified', 'pedestrian', 'service', 'footway', 'cycleway', 'track', 'path', 'platform') THEN highway END)),
'highway_' || (CASE WHEN highway IN ('pedestrian', 'service', 'footway', 'cycleway', 'track', 'path', 'platform') THEN highway END)),
('railway_' || (CASE WHEN (railway IN ('platform')
AND (tags->'location' NOT IN ('underground') OR (tags->'location') IS NULL)
AND (tunnel NOT IN ('yes', 'building_passage') OR tunnel IS NULL)
AND (covered NOT IN ('yes') OR covered IS NULL))
THEN railway END))
) AS feature
FROM planet_osm_polygon
WHERE highway IN ('residential', 'unclassified', 'pedestrian', 'service', 'footway', 'track', 'path', 'platform')
WHERE highway IN ('pedestrian', 'service', 'footway', 'cycleway', 'track', 'path', 'platform')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this adds back highway=cycleway, which is currently missing from this selection.

Do we actually want to render highway=cycleway areas?

Are there really areas where bicycles may travel freely in any direction?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't given it much thought either way. The WHERE clauses were the only places missing cycleway, we were attempting to render it in the MSS and the COALESCE

OR (railway IN ('platform')
AND (tags->'location' NOT IN ('underground') OR (tags->'location') IS NULL)
AND (tunnel NOT IN ('yes', 'building_passage') OR tunnel IS NULL)
Expand Down Expand Up @@ -764,7 +764,7 @@ Layer:
(SELECT
way,
COALESCE(
('highway_' || (CASE WHEN highway IN ('residential', 'unclassified', 'pedestrian', 'service', 'footway', 'cycleway', 'living_street',
('highway_' || (CASE WHEN highway IN ('pedestrian', 'service', 'footway', 'cycleway', 'living_street',
'track', 'path', 'platform', 'services') THEN highway END)),
('railway_' || (CASE WHEN (railway IN ('platform')
AND (tags->'location' NOT IN ('underground') OR (tags->'location') IS NULL)
Expand All @@ -774,7 +774,7 @@ Layer:
(('aeroway_' || CASE WHEN aeroway IN ('runway', 'taxiway', 'helipad') THEN aeroway END))
) AS feature
FROM planet_osm_polygon
WHERE highway IN ('residential', 'unclassified', 'pedestrian', 'service', 'footway', 'living_street', 'track', 'path', 'platform', 'services')
WHERE highway IN ('pedestrian', 'service', 'footway', 'cycleway', 'living_street', 'track', 'path', 'platform', 'services')
OR (railway IN ('platform')
AND (tags->'location' NOT IN ('underground') OR (tags->'location') IS NULL)
AND (tunnel NOT IN ('yes', 'building_passage') OR tunnel IS NULL)
Expand Down
4 changes: 0 additions & 4 deletions style/roads.mss
Original file line number Diff line number Diff line change
Expand Up @@ -2570,8 +2570,6 @@ tertiary is rendered from z10 and is not included in osm_planet_roads. */
}

#highway-area-casing {
[feature = 'highway_residential'],
[feature = 'highway_unclassified'],
[feature = 'highway_service'] {
[zoom >= 14] {
line-color: #999;
Expand Down Expand Up @@ -2613,8 +2611,6 @@ tertiary is rendered from z10 and is not included in osm_planet_roads. */
polygon-fill: @living-street-fill;
}

[feature = 'highway_residential'],
[feature = 'highway_unclassified'],
[feature = 'highway_service'] {
[zoom >= 14] {
polygon-fill: #fff;
Expand Down