Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make military=danger_area font dark pink and slanted #3072

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

kocio-pl
Copy link
Collaborator

Follow up to #3057.

Small fix to make label rendering of danger area without landuse=military still easy to recognize (hence dark pink again) and compatible with area labels rule (hence slanted):

z11
Before
aez5ysl

Current master
kkj6e 6

After
iqdw2do_

@andrzej-r
Copy link
Contributor

Yes, I just recalled we forgot to add the colour change in #3057. No problem with this change.

BTW, slanted fonts are also (somewhat confusingly) used for marking motorway exits.

@kocio-pl
Copy link
Collaborator Author

I was asking you about adding this exact change, but maybe we misunderstood each other. 😄

You should ask @matkoniecz about motorways.

@matthijsmelissen
Copy link
Collaborator

matthijsmelissen commented Feb 16, 2018

I think the proposed label color is visually not similar enough to the color of the lines. Might need some tweaking. Fine otherwise.

@kocio-pl
Copy link
Collaborator Author

Example at z23
(it's very small area in the forest, but I wanted to show how it would be with bigger area)
xhjntf4z

Under Gimp I see that new has the base color ff5555 (made lighter, of course) and the text after this change is f2143a, so not that far. But if we change it exactly to ff5555, it will look like this:
n_2yebol
v4sen3gn

Which is similar, but paler, so it might be just a tinting effect and I would rather stay with f2143a (dark pink) to be more visible. Any suggestion if/how to change it?

@kocio-pl
Copy link
Collaborator Author

Another example - colors comparison with military area and standard land color in the background on z12:
ff5555
snxoprmo
f2143a
jocwo4th

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Feb 20, 2018

I have changed the notation, so it's more clear that this is based on the same color, but the output is similar to original proposition. Any comments/reviews about it?

Example at z23

Original proposition
xhjntf4z

20% darker military (instead of 40%)
ofdatt0_

@andrzej-r
Copy link
Contributor

I'm OK with both, with slight preference for the darkened military.

20% darker military looks like a good tradeoff between making the label stand out and, at the same time, fit the colour pattern.

@kocio-pl kocio-pl merged commit c650e99 into gravitystorm:master Mar 16, 2018
@kocio-pl kocio-pl deleted the military-rework-danger branch March 16, 2018 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants