Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace rendering #2893

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Marketplace rendering #2893

merged 1 commit into from
Oct 17, 2017

Conversation

sommerluk
Copy link
Collaborator

Resolves #751 using icon number 5.

@kocio-pl
Copy link
Collaborator

Please attach real life rendering example (one or more, if this shows something interesting).

@sommerluk
Copy link
Collaborator Author

screenshot 14
screenshot 15
screenshot 16
screenshot 17
screenshot 18
screenshot 19

screenshot 3
screenshot 4
screenshot 5
screenshot 6

@dieterdreist
Copy link

dieterdreist commented Oct 15, 2017 via email

@sommerluk
Copy link
Collaborator Author

it prioritizes […] the shop dots over the market label

Well, that’s not the goal. But in the first example, as there are many other shop dots, that is our standard behaviour when there is not enough space: Something fails to render (normaly rather the text and not the icon). I’m not sure if there is much we can do about. It isn’t a typical example of marketplace tagging however.

More typical is the next example “Marché de Bradoci”, where the name renders well.

The last example has no “name” tag in the database (at least, it had no name tag when I imported the database.)

I think it is useful to have an icon, also because ¼ of the marketplaces in OSM don’t have a name.

@kocio-pl
Copy link
Collaborator

this rendering proposal doesn’t show the name well, it prioritizes the icon and the shop dots over the market label, while I believe it should be the other way round

It's a more general problem with generalization. We have no way to detect that grass is just a part of the park (so should not be visible when zooming out), the same for shops inside the market and cemetery paths - all of them can make visual noise when only "master area" should be visible.

I wanted to test Norwich Market because it's very hard case (both shops and paths are tagged extensively), yet on z17 it works reasonably well.

@sommerluk sommerluk merged commit 68131b4 into gravitystorm:master Oct 17, 2017
@sommerluk sommerluk deleted the market01 branch October 25, 2017 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants