Do not order low zoom roads by layer #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On low zoom levels (up to z9) it is not important which road crosses on top of the other. Instead, it is important to always show important roads on top, so lower classes roads do not hide motorways.
|
Rendering differences are typically minimal, except in particular circumstances with lower classed roads on top of tunnels of higher classed roads, such as here. Before: After: |
|
I support this. On this zoom levels, z_order is indeed more meaningfull than layer. |
|
I don't see the problem on the attached renderings (probably scaling would be good here to show the problem fully), but I agree with layering being not adequate on lower zoom. |
Best to look at the location of the marker in the linked map, and then to look again in the attached renderings how that part is rendered. |
|
Scaled images: |
imagico
added a commit
to imagico/osm-carto-alternative-colors
that referenced
this pull request
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On low zoom levels (up to z9) it is not important which road crosses
on top of the other. Instead, it is important to always show important
roads on top, so lower classes roads do not hide motorways.