Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering name for waterway=dock #2699

Merged
merged 1 commit into from
Sep 9, 2017
Merged

Conversation

kocio-pl
Copy link
Collaborator

Resolves #2557.

Gdańsk, z17
Before
ajwaysud
After
1thfwcba

@imagico
Copy link
Collaborator

imagico commented Jul 23, 2017

See #2701 - since i think we should drop rendering waterway=dock in general i also think we should not extend the current rendering. Especially incorrect use for mapping open harbor basins (like apparently in the example shown) would be encouraged by rendering labels.

@matthijsmelissen
Copy link
Collaborator

I agree this example is not a dock, either according to English language or according to osm's wiki.

@kocio-pl
Copy link
Collaborator Author

in general i also think we should not extend the current rendering.

This code is about rendering names with standard water label style, so I think it doesn't matter what kind of object it really is if it has a name and is related to water. I believe #2701 needs separate PR related to rendering water area, which is a different issue.

@kocio-pl kocio-pl merged commit 7b84bc5 into gravitystorm:master Sep 9, 2017
@kocio-pl kocio-pl deleted the dock-name branch September 9, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants