base placename direction parameter on geometry #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnorman
requested changes
Oct 9, 2016
There was a problem hiding this comment.
I'd rather use md5(osm_id::text) or as a second choice md5(way::bytea). Both of these are IMMUTABLE and produce TEXT which is easily manipulated.
They are also
- Faster
- clearer that they are not producing a value with meaning
- Probably less prone to edits to fiddle with label positioning
|
Interesting, I'll try that. |
Closed
…ent across metatiles
nebulon42
force-pushed
the
placename-random
branch
from
1327954
to
6d56aca
Compare
|
Changed. Interestingly, I now saw improvements with London and Valencia. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which makes it consistent across metatiles. Idea by @imagico. Ref #2378.
I have not seen any visual changes but at least we now can rule out this factor as source for misplaced labels at metatile boundaries.