Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding amenity=clinic icon #1565

Merged
merged 1 commit into from
Jun 23, 2015

Conversation

kocio-pl
Copy link
Collaborator

Resolves #763.

You can compare it with the hospital icon. As clinic may be similar, a part of the hospital (as here) or just something like doctors, it's similar to hospital, but rendered later and with less prominent name.

z16
clinic-after-z16

z17
clinic-after-z17

z18
clinic-after-z18

z19
clinic-after-z19

@dieterdreist
Copy link

Am 21.05.2015 um 00:27 schrieb kocio-pl notifications@github.com:

As clinic may be similar, a part of the hospital (as here) or just something like doctors, it's similar to hospital, but rendered later and with less prominent name.

sounds like a tagging problem, if it's big I'd rather use the hospital tag even if it's called "clinic" in your language, for reference see here
http://wiki.openstreetmap.org/wiki/Tag:amenity%3Dclinic#Meaning

and here(eg):
http://www.openstreetmap.org/relation/3334981

@kocio-pl
Copy link
Collaborator Author

The name is not important, the tagging is, and this example shows this (I also know some fast foods with "restaurant" in the name).

@nebulon42
Copy link
Contributor

I'm not sure if clinic should get its own icon. Maybe either hospital or doctors icon? This one is a bit too close to hospital. I have no different proposal for another icon though. For me the concept of clinic is not yet clear, maybe because we don't have them here.

@kocio-pl
Copy link
Collaborator Author

See the discussion in #763 - I already asked about how should it look like and ended up with it (cross alone was the first idea, however I was not really satisfied with it). I would like more people replying, but the response was too weak to really know, so I decided it would be good to be like this.

@polarbearing
Copy link
Contributor

I'm not sure if clinic should get its own icon.

Yes please. The concept fits for different aggregations of doctors in different cultures, or a rural facility that is visited by a doctor regularly.

In eastern Europe you have Polyclinics, in Germany you have the Ärztehaus, an aggregation of legally independent (self-employed) doctors in one building. From the mapping perspective, that is easier to tag in the first step than researching a dozen surgeries within.

The lighter cross in the circle works well in proximity to a hospital, but is harder to recognise when on its own.

Maybe the doctor's bag with a circle, or a roof?

@kocio-pl
Copy link
Collaborator Author

I will try with the circle, but what's the metaphor/rationale behind adding roof to the doctor's bag?

@polarbearing
Copy link
Contributor

what's the metaphor/rationale behind adding roof to the doctor's bag

doctor's bag currently used for amenity=doctors, and clinic would be "a house of doctors", roughly translating the German "Ärztehaus".

A plurality of doctors in the icon would be even better, but I have no idea how to symbolise that in a small icon.

@dieterdreist
Copy link

Am 22.05.2015 um 11:29 schrieb polarbearing notifications@github.com:

doctor's bag currently used for amenity=doctors, and clinic would be "a house of doctors", roughly translating the German "Ärztehaus".

A plurality of doctors in the icon would be even better, but I have no idea how to symbolise that in a small icon.

clinic is a bad tag because it is ambiguous (several meanings), so it remains unclear what kind of object it is

@kocio-pl
Copy link
Collaborator Author

Still got no satisfaction:
2) clinic 16-2
3) clinic 16-3 (even with using 15 pixels instead of 14)
4) clinic 16-4

The key point for me is even if there's a subtle tagging problem, the most important is what we really try to show and the clinic is definitely important health facility. Last resort for me would be showing clinic with just a plain doctor's bag, because this way we would hide all the nuances and show that this is less-than-a-hospital, but still a medical POI. This may be even more true because the doctor's office definition is also not clear: "These range from a single doctor's office to larger establishments".

What about that?

@nebulon42
Copy link
Contributor

Doctor's bag would be fine for me, but let's wait for other opinions.

@kocio-pl
Copy link
Collaborator Author

Sure - the more opinions, the more probability of doing something in a proper way.

@daganzdaanda
Copy link

After reading the wiki pages (also on doctors and health care proposals) I'm inclied to say that the doctor's bag alone is enough for "clinic". It's kind of the lowest common denominator: there will be medical help at the location, but it can be much less than a full hospital, so we should not have an icon that might be mistaken for a hospital.

@matthijsmelissen
Copy link
Collaborator

+1 for doctor's bag.

@kocio-pl kocio-pl force-pushed the clinic-icon branch 2 times, most recently from df840b9 to e826e23 Compare May 25, 2015 19:53
@kocio-pl
Copy link
Collaborator Author

General question: when should I merge new master changes? I've been fixing merge conflicts few times already with my PRs and it was good as a learning experience, but it's tedious and error prone (very long YAML lines...), so I'd rather do it only when I know someone wants to merge given PR.

@matthijsmelissen
Copy link
Collaborator

If it's simple changes I guess we can resolve the conflicts when we do the merging.

@@ -143,7 +143,7 @@ Layer:
FROM (SELECT
way, COALESCE(name, '') AS name,
('aeroway_' || (CASE WHEN aeroway IN ('apron', 'aerodrome') THEN aeroway ELSE NULL END)) AS aeroway,
('amenity_' || (CASE WHEN amenity IN ('parking', 'bicycle_parking', 'university', 'college', 'school', 'hospital', 'kindergarten', 'grave_yard', 'prison', 'place_of_worship') THEN amenity ELSE NULL END)) AS amenity,
('amenity_' || (CASE WHEN amenity IN ('parking', 'bicycle_parking', 'university', 'college', 'school', 'hospital', 'kindergarten', 'grave_yard', 'prison', 'place_of_worship', 'clinic') THEN amenity ELSE NULL END)) AS amenity,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change the landcover layer?

@kocio-pl
Copy link
Collaborator Author

I treat the clinic as a hospital, so if it's big enough, we should indicate it IMO (still it's less important, so icon is rendered bit later). I would also do it for doctor's office, because I know some of them that occupy the whole building and the area around it.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jun 3, 2015

Here is an example of doctor's office which is big, and here we have a hospital that probably does not occupy even one full building (I know both, so it's not a mistake). The differences between doctor's office, clinic and the hospital are rather blurry then, because one may think it's the size which helps recognize them, but it's not, and the name can be also misleading. That's why I support rendering areas for all such amenities as we do with hospital currently. I think different icons and zoom levels are good hints how important health facility may it be, but the area rendering should depend only on the size.

@lest69
Copy link

lest69 commented Jun 3, 2015

At least in Canada, clinics are much more similar to a doctor's office than a hospital. A doctor's office and a clinic will tend to have similar levels of care and equipment and are outpatient facilities, while a hospital will tend to be much more advanced and include things like emergency care, inpatient beds, dedicated specialty departments (e.g. renal, oncology, ICU, maternity), etc.

My opinion is that the doctor's bag would be the best choice, or possibly another different icon if someone can think of one. For me, anything similar to the hospital icon is a no-go, since they're very different facilities.

@matthijsmelissen matthijsmelissen merged commit 74a374a into gravitystorm:master Jun 23, 2015
@kocio-pl kocio-pl deleted the clinic-icon branch June 24, 2015 01:23
@Stalfur
Copy link

Stalfur commented Jul 3, 2015

I see the doctors bag is on the map now for clinic, a choice I find to be odd since many clinics, particularly in rural 3rd world, don't have doctors but nurses - with occasional visits by doctors.

I would have liked to see the thinner cross proposed at the top here instead, particularly useful also when marking wards/clinics in larger hospitals. Knowing which hospital you are going to isn't enough when it is spread around, for example Landspítalinn in Iceland is in 3 different locations spread around Reykjavík and 2 of those locations are very big with many buildings and many different entrances for different clinics.

Bring back the circle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rendering for amenity=clinic
8 participants