Add opacity to highway=proposed for less prominent rendering #1216
Conversation
|
@sb12 "The construction rules for small roads are strange(...)" comment should be moved to appear before construction rules, not before proposed rules. (preferably - without making it a separate commit) |
sb12
force-pushed
the
highway_proposed2
branch
from
786e4ab
to
10743a2
Compare
|
@mkoniecz thanks for spotting it. It should be fixed now. |
|
Is it intentional that highway=proposed is no longer rendered on z12? Code is suggesting that it is present at this zoom level, but effects are different. BTW, I am supporting dropping rendering highway=proposed from z12. https://cloud.githubusercontent.com/assets/899988/5691990/85215472-98e1-11e4-818e-eb8ceffc7558.png |
|
From test on real data - it seems this transparency is really strong, it basically removes rendering except name. Maybe it is too strong? https://cloud.githubusercontent.com/assets/899988/5692071/b1f81e32-98e5-11e4-8df8-a37a285fac9e.png https://cloud.githubusercontent.com/assets/899988/5692070/b1f5d762-98e5-11e4-9d7d-3c8f299491fa.png |
|
Thanks for the real world examples. I agree, if it's so very transparent, we can just as well leave it out. Maybe 0.3 opacity would already be enough? |
| line-width: 2; | ||
| line-color: white; | ||
| line-opacity: 0.2; | ||
| a/line-width: 2; |
There was a problem hiding this comment.
can you use more descriptive names than a b and c?
sb12
force-pushed
the
highway_proposed2
branch
2 times, most recently
from
5cad72b
to
38990df
Compare
sb12
force-pushed
the
highway_proposed2
branch
from
38990df
to
fd34d4a
Compare
|
Thank you for your feedback.
I changed the opacity to 0.3 and added an opacity to the labels as well. I also removed labels for zoom levels <=14: @mkoniecz maybe you could render some more examples with your tool. I tried to use it but I didn't know how to and couldn't find any documentation. (Does it work on Linux?)
I agree with you, so I removed rendering in zoom 12 and also changed the rendering in zoom level 13 to the one which was used in zooom level 12 before. This improves rendering of planned residential highways a lot. (I'm planning to provide a separate pull request for roads under construction which have a similar problem.) @pnorman I improved the code to be more descriptive. |
@sb12 - I was unsure whatever anybody will want to use it, so at this moment there is no documentation. Also, some features that are necessary to make it usable for other people are missing at this moment (it should change in the near future). It works on Linux. |
|
Looks goood to me, and can be merged as far as I am concerned. |
make highway=proposed rendering less prominent adds opacity and stops rendering at z12
|
@sb12 - I finally released my helper script in form that has chance to be usable for other people (https://github.com/matkoniecz/CartoCSSHelper). |
Based on the discussion in and supersedes #863.
At least partly resolves #826 and #345.
This does not add special styles for tunnels or bridges and might need some rework, when the 'proposed=*' key is available in the database.
Rendering example:
