Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give highway=bus_stop priority over amenity=shelter #4188

Closed
maro-21 opened this issue Aug 12, 2020 · 4 comments
Closed

Give highway=bus_stop priority over amenity=shelter #4188

maro-21 opened this issue Aug 12, 2020 · 4 comments

Comments

@maro-21
Copy link

maro-21 commented Aug 12, 2020

I think bus stop's names and highway=bus_stop should have priority over amenity=shelter.
For me the bus stop or the name of a bus stop is more important than a shelter.

I've recently changed public transport shelter's tagging from building=yes to amenity=shelter+shelter_type=public_transport and the name of the stop stopped rendering. On lower zooms there isn't a bus stop icon at all.

Currently shelters render at zooms 16-19 but I don't think they're so important features to do it so.

Examples

osm carto amenity shelter building osm carto amenity shelter building 2
OSM Carto bus stop priority

https://www.openstreetmap.org/node/1701715493
https://www.openstreetmap.org/node/1701723143

Current behavior

The amenity=shelter has priority over highway=bus_stop.

Expected behavior

Render highway=bus_stop over amenity=shelter.

@Adamant36
Copy link
Contributor

This is kind of a duplicate of #2431 and #3483. From what I remember a possible solution besides tweaking the rendering levels was floated in #3124. Although, it never went anywhere. It's not clear that changing rendering levels would help any. So, this might be a good candidate for z20 if it ever happens. I guess shelters could stop being rendered if tagged with shelter_type=public_transport, but that seems like an odd solution. I imagine people would want to know which bus stops have shelters when they are looking at the map.

@matkoniecz
Copy link
Contributor

Very similar to #4179

@jeisenbe
Copy link
Collaborator

jeisenbe commented Aug 31, 2020

Thank you @maro-21 - this issue is a duplicate of #2431 but it is a good idea to mention it again.

This whole issue of prioritization is also discussed more generally in #3880 where it is suggested that priority should be related to initial zoom level (though in this case both icons are first rendered at z16)

@jeisenbe
Copy link
Collaborator

Please discuss further at #2431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants