Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test more admin border colors #3526

Closed
vholten opened this issue Nov 23, 2018 · 9 comments
Closed

Test more admin border colors #3526

vholten opened this issue Nov 23, 2018 · 9 comments

Comments

@vholten
Copy link
Contributor

vholten commented Nov 23, 2018

In #3489 @kocio-pl discussed changing the color of admin borders, and tested the look of dark violet borders. He mentioned two other possibilities:

  1. Gray with a green tint, used by the German fork and @imagico's fork
  2. Plain gray, tested by @kocio-pl in Changing borders color to gray [WIP] #2695

I prefer to avoid anything involving violet for the borders, see also @Tomasz-W's comment #3489 (comment)
Here I test the results of the other two options, specifically:

  1. The German-style gray with a green tint #50705a, with a slightly darker #445f4d for low zooms (z<8)
  2. Plain gray #646464 which is a desaturated version of the German-style color, with a slightly darker #555555 for low zooms (z<8), which is the same color that @kocio-pl tested in Changing borders color to gray [WIP] #2695.

In addition, I feel that two other changes are beneficial:

  • With gray or almost gray borders, the country labels would be shown in black and therefore in the same style as city labels. To distinguish country labels from the city labels I've made them bold.
  • The second change is related to the line width of level 2 (international) borders. This line width jumps from 2 to 6 pixels between zoom 9 and 10, and I have made the change more gradual (see graph).

linewidth

z4 before
z4osm

z4 German-style color
z4ger

z4 gray
z4gray

z6 before
z6osm

z6 German-style color
z6ger

z6 gray
z6gray

z8 before
z8osm

z8 German-style color
z8ger

z8 gray
z8gray

z10 before
z10osm

z10 German-style color
z10ger

z10 gray
z10gray

z13 before
z13osm

z13 German-style color
z13ger

z13 gray
z13gray

@kocio-pl kocio-pl added the admin label Nov 23, 2018
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Nov 23, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 23, 2018

Thanks a lot for such careful testing of this version!

I like the idea of grey borders, I also agree with making countries names bold. The color is less disturbing than violet and (dark) green, while this is still possible to distinguish city names from country and state names. It also gives a map subtle visual dynamic.

It sounds good to change the width of borders more smooth, but in practice I like bold grey borders on z10 more than new ones (with tuned width).

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 23, 2018 via email

@kocio-pl
Copy link
Collaborator

@vholten Could you give a link so I could test both versions? Visually I like grey more, but maybe we need some tint to make it easier to recognize. Maybe just a mix between these two versions would work. However I feel we're pretty close to the proper rendering of borders now. I like the idea of making them a bit darker on low zooms, we can tune it too.

Perhaps the transition can happen sooner.

Maybe you're right, it's worth checking.

@Tomasz-W
Copy link

@vholten Looks very promising (both dark-green and gery), can you provide some high-zoom examples, espesially of dark-green borders crossing with protected area boundaries and gray borders crossing with power lines?

Examples of a places to test:
https://www.openstreetmap.org/#map=16/52.2837/20.3812
https://www.openstreetmap.org//#map=14/52.2336/20.5584

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 24, 2018 via email

@vholten
Copy link
Contributor Author

vholten commented Nov 24, 2018

Thanks everyone for the comments.

@kocio-pl The code for testing is now on GitHub: German-style color and gray

@Tomasz-W I tested the power line area, I will do the protected area and @jeisenbe's suggestions later.

z14 before:
z14osm

z14 German-style color:
z14ger

z14 gray:
z14gray

@kocio-pl
Copy link
Collaborator

Well, darker German green version still looks too similar to natural reserves to me:

https://www.openstreetmap.org/#map=11/54.4249/19.5443

xt2gmd5t

In a direct comparison it's better, but the labels look quite similar:

https://www.openstreetmap.org/#map=17/49.57467/22.68620

pkpsjmfk

@sommerluk
Copy link
Collaborator

About typography: Currently all country and city, town, village... labeld are “regular” fonts. Making country labels heavier (like bold here) seems a good idea.

Note than the current Noto version (the font face we are using) has not only “regular” and “bold” (almost all living scripts) but now also more font weights like “semi bold”, “black” and “light” for most scripts.

@jeisenbe
Copy link
Collaborator

This issue was more of a [WIP] PR - which continued in PRs #3666 and #3716. There is a previous issue #3489 "Change the colors of admin borders" so this issue can be closed as a duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants