-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render addr:flats or addr:unit tags like housenumber or housename #264
Comments
alternatives might be addr:door or addr:unit, but as addr:flats is used 10 times more often I'd probably go with it. Btw: why is this flats and not flat? We don't use addr:streets ;-) cheers, |
If I interpret http://wiki.openstreetmap.org/wiki/Key:addr:flats correctly, the tag is thougth for ranges too. So if there are multiple flats in that building section (e.g. multiple floors) you use addr:flats=3-7. |
TODO: we should clean up usage of addr:flatnumber and building:flats at some point, if they aren't correct. The fact they lack a wiki article and are used far less is a good indication of where the community is heading. |
Another example, slightly different style - You can see the "bbg:unit_number", which is obviously the same semantic meaning. Within Australia, we'd write the postal address as one of Unit 1, 2 Example Street, Suburbname STATE postcode For most Australians, if you saw "1/600", "2/600"; it would be confusing but understandable. However, you'd still expect the building itself to be "600", and only if you went for a low zoom level to perhaps see the unit numbers. A second problem this potentially introduces: high rise apartment buildings or anything multi story. It would be hard to decide which takes precedence in the 2d rendering, if any. For something like the 3d building maps, not as much of an issue. @saerdnaer - how similar to your scenario is what I describe about AU conventions? |
In Germany, we normally don't write the unit/apartment number as part of the address. Every entrance normally get's it's own house number, sometimes with an additional suffix. In the student home neighborhoods I lived is was common to have one big post box facility per house number. Each post box is only labeled with the apartment number. The mailman can deliver letters to the correct postbox by locking up the surname (and the first letter of the prename) in a list posted in a glas box on the wall. |
So what kind of tag should I use in the pull request? addr:flats? |
I don't think any of these tags are in the .style file, and new feature requests involving .style updates aren't going to be handled right away. The wiki defines addr:flats, addr:door and addr:unit as semantically different. Something to remember is that there are numbers out there involving dashes. |
There is another case example of an apartment complex, using addr:housenumber and addr:unit, with detailed info over at the OSM Help Forum. I am open to any solution tagging-wise, but the rendered result should look better than right now, see the link, and if not too cluttered, include the flat/unit number at high zoom level. Post solution here please, so that I can finish tagging that apartment complex. Thanks. |
Now |
I would prefer addr:unit instead, as this handles everything along that
same general concept, including private mailboxes, apartments, office
suites, townhouses, trailer park lots, campsites, etc.
…On Mon, May 29, 2017 at 7:28 AM, Minh Nguyễn ***@***.***> wrote:
alternatives might be addr:door or addr:unit, but as addr:flats is used 10
times more often I'd probably go with it.
Now addr:unit is used twice as much as addr:flats. (openstreetmap/iD#3980
<openstreetmap/iD#3980> would add addr:unit to
iD, which would likely increase usage of this field where unit numbers are
erroneously placed in addr:housenumber or addr:street.)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#264 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACwyhsOsid9uupaE1t63fBndYUk1piIRks5r-rn_gaJpZM4BM8UB>
.
|
For reference – here is link to a TagInfo comparison view: https://taginfo.openstreetmap.org/compare/addr:unit/addr:flats/addr:door/addr:housename |
I don't have local knowledge on the original example, but I think the correct way to tag it would be to use, for example, addr:unit="Q" and addr:flats="59" and perhaps also building:part=yes for the ways defining separate flats. Currently the tagging is addr:housename="Q59" and building=yes. Release 4.4.0 added rendering of addr:unit, so rendering of addr:flats would still be needed to fix this issue. |
We render addr:unit since #2494. |
Before I create a pull request, a little discussion:
We in munich have a problem with the tagging of one of the student home neighborhoods. There is a area where every building has the same offical housenumber, but each apartment has it's own building entrance and a own apartment number. Basically an extreme version of terraced housing.
Some user used this appartment number as content for addr:housenumber. In the discussion at our local meeting we came to the conclusion to use addr:flats insteat, but this is not rendered yet.
Is this the right tag to use, or would you prefer an other one?
More information:
http://www.openstreetmap.org/#map=19/48.17930/11.55186
http://www.studentenwerk-muenchen.de/typo3temp/pics/b9b5aaba19.jpg
The text was updated successfully, but these errors were encountered: