This repository has been archived by the owner on Oct 20, 2021. It is now read-only.
feat: global markdown template pages #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytvnr
force-pushed
the
issues/4465-markdown-template-pages
branch
from
3fdf35b
to
8edc732
Compare
gcusnieux
reviewed
Feb 23, 2021
Comment on lines
+213
to
+217
| <div class="gv-page-info-banner" ng-hide="!$ctrl.page.content"> | ||
| <ng-md-icon icon="info" class="gv-info"></ng-md-icon> | ||
| Selecting a template will override the current documentation. | ||
| </div> | ||
|
|
There was a problem hiding this comment.
Could we make it ui-components ?
And you can use gv-icon instead of ng-md-icon
There was a problem hiding this comment.
issue created here : gravitee-io/gravitee-ui-components#288
| @@ -18,7 +18,8 @@ | |||
| <div> | |||
| <div class="gv-page-draft-banner" ng-if="!$ctrl.page.published"> | |||
| <ng-md-icon icon="warning" class="gv-warning"></ng-md-icon> | |||
| This page is not published yet and will not be visible to other users | |||
| {{$ctrl.isMarkdownTemplate() ? 'This page is not available for users yet' : | |||
| 'This page is not published yet and will not be visible to other users' }} | |||
There was a problem hiding this comment.
I wonder if it's not better to move this in the controller to facilitate the merges
| } | ||
|
|
||
| /* | ||
| * Analytics | ||
| */ | ||
| analytics(request) { | ||
| var url = this.environmentURL + '/analytics?'; | ||
| var url = this.Constants.env.baseURL + '/analytics?'; | ||
| var keys = Object.keys(request); |
There was a problem hiding this comment.
We could update the var with const or let
|
Also, we have a problem with the horizontal scrollbar
And we could make the form a bit more compact by using two columns for the small fields |
|
horizontal issue is here : gravitee-io/issues#5119 |
ytvnr
force-pushed
the
issues/4465-markdown-template-pages
branch
2 times, most recently
from
6e55f52
to
cd72536
Compare
ytvnr
force-pushed
the
issues/4465-markdown-template-pages
branch
from
cd72536
to
013310d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gravitee-io/issues#4465