Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable auto-enroll via environment variable #47679

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codingllama
Copy link
Contributor

Users or remote admins can now set TELEPORT_DEVICE_AUTO_ENROLL_DISABLED=1 to disable auto-enroll in their machine, regardless of cluster setting.

Changelog: Auto-enroll may be locally disabled using the TELEPORT_DEVICE_AUTO_ENROLL_DISABLED=1 environment variable

@codingllama
Copy link
Contributor Author

This one is a bit experimental, but I think it could help if a customer wants to automatically exclude a certain category of machines from auto-enroll.

@rosstimothy
Copy link
Contributor

This one is a bit experimental

For these kinds of things we've been using TELEPORT_UNSTABLE_FOO

@codingllama
Copy link
Contributor Author

codingllama commented Oct 17, 2024

This one is a bit experimental

For these kinds of things we've been using TELEPORT_UNSTABLE_FOO

It's not experimental in that sense, it was more in that I was still looking for confirmation on whether it would be useful. The answer is "yes" so I think the proposed env var is better.

@rosstimothy
Copy link
Contributor

One of the other reasons the TELEPORT_UNSTABLE prefix has been used is to prevent people from relying on the environment variables longterm. Is this going to be a thing in perpetuity or do you plan on removing this in favor of another mechanism in the future? If the latter I think the TELEPORT_UNSTABLE prefix should be used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants