feat: SSO MFA - Add SSOMFASessionData
#47647
Open
+189
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
added
the
no-changelog
espadolini
reviewed
Oct 17, 2024
espadolini
approved these changes
Oct 17, 2024
espadolini
reviewed
Oct 17, 2024
| return trace.BadParameter("missing parameter Username") | ||
| } | ||
|
|
||
| value, err := json.Marshal(sd) |
There was a problem hiding this comment.
If this is a brand new type I'd strongly recommend protojson, FWIW.
edit: nevermind, it's specifically defined as JSON
There was a problem hiding this comment.
The struct contains a protobuf-defined type; is that currently (wrongly) marshaled and unmarshaled with encoding/json?
There was a problem hiding this comment.
I suppose so, what issues does this cause? We are already json marshalling *mfav1.ChallengeExtensions in the webauthn session data as well.
There was a problem hiding this comment.
Do you think a custom marshaller on services.SSOMFASessionData to protojson.Marshal the challenge extensions is warranted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the implementation of SSO MFA
Adds the storage of
SSOMFASessionData. This will be used in follow up PRs to complete the SSO MFA flow.